[FFmpeg-devel] [PATCH] Make pp_help a constant array of characters

[Michael Niedermayer]

On Thu, Jan 03, 2008 at 02:16:32AM +0100, Diego 'Flameeyes' Petten? wrote:
> 
> While I was there I seen pp_help being a literal pointer (marked char*),
> as far as I can see it's constant, so it should be in .rodata rather
> than .data in my opinion. The attached patch takes care of that.
[...]
> --- a/libpostproc/postprocess.c
> +++ b/libpostproc/postprocess.c
> @@ -697,7 +697,7 @@ static inline void postProcess(uint8_t src[], int srcStride, uint8_t dst[], int
>  
>  /* -pp Command line Help
>  */
> -char *pp_help=
> +const char pp_help[] =
>  "Available postprocessing filters:\n"

breaks ABI

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080103/64017aef/attachment.pgp>