[FFmpeg-devel] [PATCH] Realmedia / RTSP (RDT)

[Michael Niedermayer]

On Tue, Jan 01, 2008 at 02:36:35PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> you mentioned in previous threads that you'd like to do one patch, so I'll
> try to keep patches separate in coming replies. This one is for the
> rtsp-flags-field.patch.
> 
> On Dec 29, 2007 7:43 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > > -                av_new_packet(pkt, len);
> > > -                memcpy(pkt->data, buf, len);
> > > -            }
> > > +            av_new_packet(pkt, len);
> > > +            memcpy(pkt->data, buf, len);
> >
> > cosmetic
> 
> 
> Fixed. New version attached without the above. I attach a second patch
> (sorry :-) ) which does the reindent separately (it's ok to do reindent
> patches in the same reply, because they don't really do anything, right?).
[...]
> @@ -671,6 +671,8 @@
>              s->read_buf_index = 0;
>              return 1;
>          }
> +    } else if (s->parse_packet) {
> +        rv= s->parse_packet(s, pkt, &timestamp, buf, len, flags);
>      } else {
>          // at this point, the RTP header has been stripped;  This is ASSUMING that there is only 1 CSRC, which in't wise.
>          switch(st->codec->codec_id) {
> @@ -726,12 +728,8 @@
>              rv= 0;
>              break;
>          default:
> -            if(s->parse_packet) {
> -                rv= s->parse_packet(s, pkt, &timestamp, buf, len);
> -            } else {
> -                av_new_packet(pkt, len);
> -                memcpy(pkt->data, buf, len);
> -            }
> +            av_new_packet(pkt, len);
> +            memcpy(pkt->data, buf, len);
>              break;
>          }

now, this part looks like a unrelated simplification, i think its ok 
(rtp maintainer?) but i think it should be in a seperate patch
and without the reindention


[...]

> Index: ffmpeg/libavformat/rtp_internal.h
> ===================================================================
> --- ffmpeg.orig/libavformat/rtp_internal.h	2007-11-24 22:36:33.000000000 -0500
> +++ ffmpeg/libavformat/rtp_internal.h	2007-12-27 17:27:23.000000000 -0500
> @@ -46,7 +46,7 @@
>                                                  AVPacket * pkt,
>                                                  uint32_t *timestamp,
>                                                  const uint8_t * buf,
> -                                                int len);
> +                                                int len, int flags);
>  
>  typedef struct RTPDynamicProtocolHandler_s {
>      // fields from AVRtpDynamicPayloadType_s

could you please document per doxygen comment (in a .h file) what flags is
good for (yes i really have forgotton, i just remember it was needed for
subsequent patches)


> Index: ffmpeg/libavformat/rtp.c
> ===================================================================
> --- ffmpeg.orig/libavformat/rtp.c	2008-01-01 14:31:29.000000000 -0500
> +++ ffmpeg/libavformat/rtp.c	2008-01-01 14:31:53.000000000 -0500
> @@ -728,8 +728,8 @@
>              rv= 0;
>              break;
>          default:
> -                av_new_packet(pkt, len);
> -                memcpy(pkt->data, buf, len);
> +            av_new_packet(pkt, len);
> +            memcpy(pkt->data, buf, len);
>              break;
>          }

that one is ok of course

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080102/000af282/attachment.pgp>