[FFmpeg-devel] [PATCH] incorrect return type for opt_bitrate/type safety

Rich Felker dalias
Wed Jan 2 02:18:33 CET 2008


On Wed, Jan 02, 2008 at 12:46:38AM +0100, Michael Niedermayer wrote:
> > @@ -204,7 +204,7 @@
> >  static int nb_frames_dup = 0;
> >  static int nb_frames_drop = 0;
> >  static int input_sync;
> > -static uint64_t limit_filesize = 0; //
> > +static int64_t limit_filesize = 0; //
> 
> filesize is not signed

While negative values make no sense, the type derives from off_t which
is necessarily signed, so it doesn't really matter.

Rich




More information about the ffmpeg-devel mailing list