[FFmpeg-devel] [PATCH] add uuid box to MP4 to make h.264 play on iPod

Baptiste Coudurier baptiste.coudurier
Fri Feb 29 01:00:40 CET 2008


Hi,

Michael Niedermayer wrote:
> On Sun, Feb 24, 2008 at 07:38:11PM +0000, Mark Himsley wrote:
>> Michael Niedermayer wrote:
>>> On Sun, Feb 24, 2008 at 04:41:26PM +0000, Mark Himsley wrote:
>>>> Michael Niedermayer wrote:
>>>>> On Sat, Feb 23, 2008 at 12:14:43PM +0000, Mark Himsley wrote:
>>>>>   
>>>>>> -    else if(track->enc->codec_id == CODEC_ID_H264)
>>>>>> +    else if(track->enc->codec_id == CODEC_ID_H264) {
>>>>>>          mov_write_avcc_tag(pb, track);
>>>>>> +        if(track->mode == MODE_IPOD)
>>>>>> +            mov_write_uuid_tag_ipod(pb);
>>>>>> +    }
>>>>>>     
>>>>> Why is this h.264 specific?
>>>>>   
>>>> Because, as I understand it, the uuid tag is only required by Apple for 
>>>> H.264 material.
>>> Remove the h264 check please, unless it breaks other files on the ipod OR
>>> apples own tools omit it as well.
>> Apple's own tools omit the uuid tag unless they are outputting H.264. i.e.
>>
>> * Apple QuickTime Pro does NOT output the uuid tag with MPEG 4 part 2 video 
>> in an MP4 container.
>>
>> * Apple QuickTime Pro DOES output the uuid tab with MPEG4 part 10 video in 
>> an MP4 container.
>>
>>
>>> doxygen compatible comments please
>> I'm trying to :-)
> 
> patch looks ok
> 

Yes except that it misses Makefile update and avformat.h minor version
bump. Changelog and documentation too ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312




More information about the ffmpeg-devel mailing list