[FFmpeg-devel] [RFC] remove illegal WAV tags

[Reimar Döffinger]

On Wed, Feb 27, 2008 at 11:55:08PM +0100, Diego Biurrun wrote:
> I just tried and NUV files seem to work in both ffplay and MPlayer even
> without this hack.  Is this still needed?  What for?

You obviously got the wrong NUV file I'd say.
I did send a patch that removes them and adds replacement code ages ago though.

> Index: libavformat/riff.c
> ===================================================================
> --- libavformat/riff.c	(revision 12270)
> +++ libavformat/riff.c	(working copy)
> @@ -213,12 +213,6 @@
>      { CODEC_ID_FLAC,            0xF1AC },
>      { CODEC_ID_ADPCM_SWF,       ('S'<<8)+'F' },
>      { CODEC_ID_VORBIS,          ('V'<<8)+'o' }, //HACK/FIXME, does vorbis in WAV/AVI have an (in)official id?
> -
> -    /* FIXME: All of the IDs below are not 16 bit and thus illegal. */
> -    // for NuppelVideo (nuv.c)
> -    { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
> -    { CODEC_ID_MP3,       MKTAG('L', 'A', 'M', 'E') },
> -    { CODEC_ID_MP3,       MKTAG('M', 'P', '3', ' ') },

Also according to git-blame the last entry is for nut, not nuv.