[FFmpeg-devel] [PATCH] fix build with --disable-encoders

Michael Niedermayer michaelni
Mon Feb 25 23:09:41 CET 2008

On Mon, Feb 25, 2008 at 10:13:00PM +0100, Aurelien Jacobs wrote:
> Michael Niedermayer wrote:
> > On Sun, Feb 24, 2008 at 02:44:09PM +0100, Diego Biurrun wrote:
> > > 
> > > It might be good to split off encoding-related stuff from that file
> > > but this question is orthogonal to adding one more #ifdef.
> > 
> > No, its not orthogonal, ifdef CONFIG_ENCODERS is specific to the case
> > of mixed encoder and decoder code, if its split the encoder ifdefs
> > become unneeded.
> OK. Attached patch splits encoding part of dsputil_mmx in its own file.
> It removes all #ifdef CONFIG_ENCODERS without adding any warning,
> without needing -wno-whatever.
> It should please everyone.
> (Note that the patch is compressed because it's big, but basically, it
> only moves encoder functions to dsputilenc_mmx.c)
> I guess the patch is OK, so I will apply it very soon.

Ok except dsputilenc_mmx.h, i think we dont need a new header for a single
line of code, that can as well stay in dsputil.h.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080225/9933a270/attachment.pgp>

More information about the ffmpeg-devel mailing list