[FFmpeg-devel] [PATCH] remove MSVC-specific

[Måns Rullgård]

Eddie Pang wrote:
> On 25/02/2008, Diego Biurrun <diego at biurrun.de> wrote:
>> Here is a patch to remove an MSVC-specific definition from
>>  libavutil/mem.h.  MSVC is not supported and now we have a proper
>>  fallback.  Besides, it seems that the identifier is wrong anyway
>>  and the condition is never true.  This proves that if there should be
>>  any sort of MSVC support, it should be maintained outside of FFmpeg
>>  where it might actually get some testing.
>
> Hello,
>
> Someone has just e-mailed me about this - the identifier should be
> _MSC_VER (not _MSVC).  (See
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-February/042582.html).
>
> Also, that conditional is needed as the #warning directive isn't
> available in Visual C++.

#warning is not standard C (#error is).

-- 
M?ns Rullg?rd
mans at mansr.com