[FFmpeg-devel] [PATCH] ACT demuxer

[Michael Niedermayer]

On Sun, Feb 24, 2008 at 08:06:21PM +0100, Reimar D?ffinger wrote:
> On Sun, Feb 24, 2008 at 07:36:17PM +0100, Michael Niedermayer wrote:
> > > +    if (st->codec->sample_rate == 4400) {
> > > +        st->codec->frame_size=11;
> > > +        av_set_pts_info(st, 64, 20, 1000);
> > > +    }else if (st->codec->sample_rate == 8000) {
> > > +        st->codec->frame_size=10;
> > > +        av_set_pts_info(st, 64, 10, 1000);
> > > +    }else
> > > +        return AVERROR_NOFMT;
> > 
> > frame_size is set to invalid values, correct is 80 and 88 IIRC
> 
> Sorry for being lazy, but what is frame_size supposed to indicate
> anyway?

    /**
     * Samples per packet, initialized when calling 'init'.
     */
    int frame_size;


> 
> > and
> > av_set_pts_info(st, 64, st->codec->frame_size, st->codec->sample_rate);
> [...]
> > > +    st->duration=(1000*(min*60+sec)+msec)/st->time_base.num;
> 
> This brings up another thing... I do not mind much, but is this better
> like this or would it be better to always do
> av_set_pts_info(st, 64, 1, 1000);
> 
> and instead set pkt->duration to either 10 or 20?

ohhh well ...
time for bikeshed wars :)

of course it should be 
av_set_pts_info(st, 64, 1, 100);
and
av_set_pts_info(st, 64, 1, 50);
with duration=1;
:)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080224/7153296c/attachment.pgp>