[FFmpeg-devel] [PATCH] fix build with --disable-encoders

Alexander Strange astrange
Sat Feb 23 19:13:15 CET 2008

On Feb 23, 2008, at 7:22 AM, M?ns Rullg?rd wrote:

> Alexander Strange <astrange at ithinksw.com> writes:
>> On Feb 22, 2008, at 2:56 PM, Michael Niedermayer wrote:
>>> Why is there an #ifdef CONFIG_ENCODERS there at all?
>>> Its gccs job to omit unused static functions.
>>> [...]
>> Well, if you want...
>> Attached patches:
>> * remove those uses of CONFIG_ENCODERS from dsputil_mmx
>> * add -Wno-unused-function to the build
> I don't like this.  The warning about unused stuff often helps spot
> dead code that should be removed.

Let's only add it for --disable-encoders, then. I'd rather not mark  
everything in dsputil_mmx as unused since there's a lot of functions  
and they usually are used, so that would have the same problem. Some  
other files (h263, msmpeg4) also put static functions under  
CONFIG_ENCODERS; they'll have the same problem if anyone changes that.

It's too bad 'enabled encoders' is only set lower down, but I don't  
think it's too unclean. I could move this line down there, of course.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-wno-unused-functions2.diff
Type: application/octet-stream
Size: 398 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080223/47b9711c/attachment.obj>
-------------- next part --------------

More information about the ffmpeg-devel mailing list