[FFmpeg-devel] [PATCH] a couple of updates for MPEGTS

[Nico Sabbi]

Il Tuesday 19 February 2008 01:26:38 M?ns Rullg?rd ha scritto:

> 
> You could move p += program_info_length statements (this one and the
> one below) just after the while loop.  Adding zero will do no harm.

done

> 
> > +            break;
> > +        }
> > +        tag = get8(&p, p_end);
> > +        len = get8(&p, p_end);
> > +        if(len == -1 || len > program_info_length - 2) {
> 
> You need to declare len as int to compare it to -1.  Like this, a
> return value of -1 will turn into a seemingly valid 255.

done

> 
> As I've said, I don't like the way this looks, neither before nor
> after the patch.  Unfortunately, I can't think of an easy way of
> cleaning it up, and I'm working on a better ts demuxer anyway.
> 

I see, but until you have finished porting your demuxer may I commit it?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dts-reg5.diff
Type: text/x-diff
Size: 2880 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080222/72786d9e/attachment.diff>