[FFmpeg-devel] [PATCH] make fast option with h264 actually do something..

[Rich Felker]

On Tue, Feb 19, 2008 at 09:22:31PM +0100, Michael Niedermayer wrote:
> On Tue, Feb 19, 2008 at 09:10:38PM +0100, Michael Niedermayer wrote:
> > On Tue, Feb 19, 2008 at 01:26:24AM -0500, Rich Felker wrote:
> > > Currently, the FAST flag for h264 only affects motion functions for
> > > non-ref frames, making it mostly useless. This patch makes it affect
> > > all motion compensation. Benchmarks on my K6, using mplayer
> > > -benchmark:
> > > 
> > > Without fast: 17.6 sec
> > > With current fast: 17.2 sec
> > > With patch applied: 16.6 sec
> > > 
> > > I did not notice any visible corruption, but even if there is some,
> > > that's the idea of the 'fast' flag...
> > > 
> > > Comments welcome.
> > 
> > patch ok
> 
> after some more carefull tests, i retract that approval, patch rejected,
> it breaks decoding of BA1_FT_C.264 with very vissible artifacts.

Would it be possible to make the level configurable or to at least
apply the fast-mode to all B-frames instead of only non-reference
ones? Error should not have time to sufficiently accumulate during
B-frame sequences, only over long intervals between I-frames.

Rich