[FFmpeg-devel] [PATCH] use standard macro for ATTR_ALIGN

[Michael Niedermayer]

On Tue, Feb 19, 2008 at 09:22:33AM +0100, Diego Biurrun wrote:
> On Wed, Feb 13, 2008 at 02:19:56AM +0100, Diego Biurrun wrote:
> > On Tue, Feb 12, 2008 at 04:22:03PM +0100, Michael Niedermayer wrote:
> > > On Tue, Feb 12, 2008 at 08:59:13AM +0100, Diego Biurrun wrote:
> > > > On Tue, Feb 12, 2008 at 01:59:20AM +0100, Michael Niedermayer wrote:
> > > > > On Tue, Feb 12, 2008 at 12:32:57AM +0100, Diego Biurrun wrote:
> > > > > > libavcodec/i386/idct_mmx.c duplicates a somewhat simplified version of
> > > > > > DECLARE_ALIGNED as ATTR_ALIGN.
> > > > > > 
> > > > > > Here is a patch to replace it with DECLARE_ALIGNED.  OK to apply?
> > > > > 
> > > > > idct_mmx.c is from libmpeg2 and i see no sense in making future merges
> > > > > from or to code from libmpeg2 harder.
> > > > > 
> > > > > Thus iam against ALL cosmetic changes to it, that includes the ones done
> > > > > already.
> > > > 
> > > > Don't hold your breath, libmpeg2 has been orphaned for years...
> > > 
> > > Everyone forks it, the forks are not orphaned. Merges between them will
> > > be very hard ...
> > > 
> > > Just try
> > > diff -u  libmpeg2/idct_mmx.c libavcodec/i386/idct_mmx.c
> > 
> > Your diffing skills leave something to be desired, the flags -e -E -w -B
> > will be helpful.
> > 
> > > in mplayer and be surprised by how many cosmetics and few functional
> > > changes are there already. Actually i dont even know if there are
> > > any functional changes, its kinda hard to notice in >800 lines of
> > > changes. :)
> > 
> > Fixed.
> 
> Is the patch acceptable now that there are no cosmetic changes left?

If its accepted upstream we should have it in our code too, if not (upstream
lacks that DECLARE_ALIGNED IIRC) i dont see why we would want that
difference.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080219/f8536455/attachment.pgp>