[FFmpeg-devel] [PATCH] Clean up lib* version definitions

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Feb 17, 2008 at 06:14:31PM +0000, Mans Rullgard wrote:
>> Updating version numbers now requires changing only one place.
>> ---
>>  configure                 |    2 +-
>>  libavcodec/avcodec.h      |    6 ++++--
>>  libavdevice/avdevice.h    |    6 ++++--
>>  libavformat/avformat.h    |    6 ++++--
>>  libavutil/avutil.h        |   12 ++++++++++--
>>  libpostproc/postprocess.h |    6 ++++--
>
>>  6 files changed, 27 insertions(+), 11 deletions(-)
>
> Hmm, this more than doubles the number of lines of code, and requires

The new macros aside, it's replacing two lines with three in each
header file (plus a blank line I thought looked better).  That's not
what I call more than double.

> the reader to understand/guess the meaning for an additional layer of
> macros.

I'd be happy to add a comment explaining them.

> Do you really think this is a good idea?

People have forgotten to update both sets of version numbers on
occasion, and there's been a much messier patch posted in the past.
IMHO, having the same information in two (or more) places is always
bad.

If you don't like it, I'll drop it.

-- 
M?ns Rullg?rd
mans at mansr.com