[FFmpeg-devel] [patch] do not run ldconfig for DESTDIR installs

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sat, Feb 16, 2008 at 01:31:48PM +0000, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
>> 
>> > On Sat, Feb 16, 2008 at 10:59:50AM +0200, ?smail D?nmez wrote:
>> >> On Feb 16, 2008 4:24 AM, Mike Frysinger <vapier.adi at gmail.com> wrote:
>> >> 
>> >> > running ldconfig when not installing into system paths can waste
>> >> > significant cpu and i/o time.  DESTDIR is generally used in two
>> >> > scenarios:
>> >> >  - package maintainers installing into an empty tree for packaging
>> >> >  - cross-compilers installing into a development tree
>> >> > in neither of these scenarios does running ldconfig make sense nor is
>> >> > it useful.  the paths the libraries get installed into are rarely (ive
>> >> > never heard of a case) declared in the ldso's configuration file, so
>> >> > running ldconfig doesnt actually accomplish the intended goal: getting
>> >> > the newly installed ffmpeg libs into the cache and symlinks created.
>> >> >
>> >> 
>> >> Agreed, please apply the patch.
>> >
>> > There are at least two paths where it makes sense to run: /usr/local and
>> > /usr. Whereas for the other cases I usually encounter building is done
>> > as ordinary user and thus ldconfig can not run.
>> 
>> I'd much rather remove the running of ldconfig entirely.  The actions,
>> if any, required when installing shared libraries are highly
>> system-dependent, and ldconfig covers but a few.  As has been pointed
>> out, it is also useless if installing to a location not in the normal
>> shared library search path, or if installing as non-root.  Besides,
>> everybody's favourite autotools do not run ldconfig from make install.
>> They do print a (very annoying) message advising that something might
>> have to be done, but take no explicit action.
>> 
>> Unless I hear compelling arguments to keep running ldconfig, I'll be
>> removing it soon.
>
> I say remove it now.

Done.

-- 
M?ns Rullg?rd
mans at mansr.com