[FFmpeg-devel] [patch] allow build env to force sdl-config path via $SDL_CONFIG

[Måns Rullgård]

"Mike Frysinger" <vapier.adi at gmail.com> writes:

> On Thu, Feb 14, 2008 at 6:39 PM, Diego Biurrun <diego at biurrun.de> wrote:
>> On Wed, Feb 13, 2008 at 10:42:43PM -0500, Mike Frysinger wrote:
>>  > as is standard with pretty much all autotool-based build systems which
>>  > search for the sdl-config script, this patch allows people to force
>>  > the full path to sdl-config via the SDL_CONFIG env var.  so now you
>>  > can do:
>>  > SDL_CONFIG=/some/crazy/stupid/place/sdl-config ./configure
>>  > and ffmpeg will find the crazy stupid sdl
>>  >
>>  > --- configure (revision 11931)
>>  > +++ configure (working copy)
>>  > @@ -1693,7 +1693,7 @@ check_foo_config freetype2 freetype ft2b
>>  >
>>  >  disable sdl_too_old
>>  >  disable sdl
>>  > -SDL_CONFIG="${cross_prefix}sdl-config"
>>  > +SDL_CONFIG="${SDL_CONFIG-${cross_prefix}sdl-config}"
>>                            ^
>>  This '-' looks wrong.
>>
>>  Also, why can't you simply use PATH?
>
> the location of the sdl-config wrapper may contain binaries that
> cannot be executed on the host.  i dont see why there's any objection
> to the change considering this behavior is perfectly standard for
> every autotool based package out there that looks for sdl-config.
>
> if you wanted to decrapify the ffmpeg configure script, you'd start
> using pkg-config which is much easier to control in a cross-compiling
> environment.  then people would only have to set one variable
> (PKG_CONFIG) or create one wrapper script (${cross_prefix}pkg-config).

If you want a nice reception around here, you'd start by not calling
the configure script crap.

-- 
M?ns Rullg?rd
mans at mansr.com