[FFmpeg-devel] [patch] allow build env to force sdl-config path via $SDL_CONFIG

[Diego Biurrun]

On Thu, Feb 14, 2008 at 11:46:26PM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Wed, Feb 13, 2008 at 10:42:43PM -0500, Mike Frysinger wrote:
> >> as is standard with pretty much all autotool-based build systems which
> >> search for the sdl-config script, this patch allows people to force
> >> the full path to sdl-config via the SDL_CONFIG env var.  so now you
> >> can do:
> >> SDL_CONFIG=/some/crazy/stupid/place/sdl-config ./configure
> >> and ffmpeg will find the crazy stupid sdl
> >> 
> >> --- configure	(revision 11931)
> >> +++ configure	(working copy)
> >> @@ -1693,7 +1693,7 @@ check_foo_config freetype2 freetype ft2b
> >>  
> >>  disable sdl_too_old
> >>  disable sdl
> >> -SDL_CONFIG="${cross_prefix}sdl-config"
> >> +SDL_CONFIG="${SDL_CONFIG-${cross_prefix}sdl-config}"
> >                            ^
> > This '-' looks wrong.
> 
> I think it looks intentional.

Indeed, parameter expansion sleight of hand.  Is this POSIX-compatible?
bash, dash and zsh understand it here, but I'm sceptical.  I'm sure you
can tell me where to look it up, though.

> > Also, why can't you simply use PATH?
> 
> Good question.

So unless we hear a good reason why this cannot simply work with PATH,
this patch is rejected.

Diego