[FFmpeg-devel] [PATCH] remove MSVC cruft

Reimar Döffinger Reimar.Doeffinger
Tue Feb 12 17:19:28 CET 2008


Hello,
On Tue, Feb 12, 2008 at 05:12:07PM +0100, Michael Niedermayer wrote:
> On Tue, Feb 12, 2008 at 04:39:24PM +0100, Reimar D?ffinger wrote:
> > working code > broken at compile-time >>> broken at runtime.
> 
> you forget:
> working > broken
> 
> and a #error in the default case _BREAKS_ ALL non GNU compilers, ffmpeg
> would no longer need just ISO C + POSIX but GNU

Yes, but your suggestion would/could land at "broken at runtime" with
some compilers.
And because one is maybe more likely but just > vs. >>> #error wins for
me.
But the discussion about this has already wasted more time than it
should, do it however you want, though I do not think the #warning has
any real value.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list