[FFmpeg-devel] [PATCH] [1/??] [3/3] Colorspace negotiation

[Michael Niedermayer]

On Sun, Feb 10, 2008 at 06:15:04PM +0100, Vitor Sessak wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > On Sun, Feb 10, 2008 at 09:37:07AM +0100, Vitor Sessak wrote:
> >> Hi
> >>
> >> Michael Niedermayer wrote:
> >>> On Sun, Feb 10, 2008 at 12:30:54AM +0100, Vitor Sessak wrote:
> >>>> Michael Niedermayer wrote:
> >>>>> On Sat, Feb 09, 2008 at 11:07:14PM +0100, Vitor Sessak wrote:
> >>>>>> Hi and thanks for the review,
> >>>>>>
> >>>>>> Michael Niedermayer wrote:
> >>>>>>> On Sat, Feb 09, 2008 at 07:33:04PM +0100, Vitor Sessak wrote:
> >>>>>>>
> >>>> [...]
> >>>>
> >>>>>>> I dont like this, something based on PIX_FMT_NB should work better
> >>>>>> Agree with all of the above. Modified code in 
> >>>>>> http://svn.mplayerhq.hu/soc/libavfilter/formats.c?content-type=text%2Fplain&view=co 
> >>>>>>    av_free(a->refs);
> >>>>>>    av_free(a->formats);
> >>>>>>    av_free(a);
> >>>>>>
> >>>>>>    av_free(b->refs);
> >>>>>>    av_free(b->formats);
> >>>>>>    av_free(b);
> >>>>> these can also be moved into merge_ref()
> >>>>>
> >>>>>
> >>>>> [...]
> >>>>>
> >>>>>>    int idx;
> >>>>>>
> >>>>>>    if((idx = find_ref_index(ref)) >= 0)
> >>>>> int idx= find_ref_index(ref);
> >>>>>
> >>>>> if(idx >= 0)
> >>>>>
> >>>>> and there are more of these
> >>>>>
> >>>>>
> >>>>> [...]
> >>>> Both done (in soc svn).
> >>> looks ok
> >> Is it necessary to copy the whole svn history? 
> > 
> > It would be nice, iam not insisting on it though.
> 
> Do you think I can commit it right away, or should I wait for the rest?

commit

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080210/199ff182/attachment.pgp>