[FFmpeg-devel] [PATCH] Fix ffmpeg crash on G3 based computers introduced with revision 10637

[Michael Niedermayer]

On Sat, Feb 09, 2008 at 05:20:47PM +0000, Patrice Bensoussan wrote:
> 
> On 9 Feb 2008, at 17:18, Diego Biurrun wrote:
> 
> > On Sat, Feb 09, 2008 at 06:13:53PM +0100, Diego Biurrun wrote:
> >> On Sat, Feb 09, 2008 at 02:45:49PM +0100, Michael Niedermayer wrote:
> >>> On Sat, Feb 09, 2008 at 12:41:47PM +0000, Patrice Bensoussan wrote:
> >>>>
> >>>> On 9 Feb 2008, at 12:22, Reimar D?ffinger wrote:
> >>>>
> >>>>> On Sat, Feb 09, 2008 at 12:11:01PM +0000, Patrice Bensoussan  
> >>>>> wrote:
> >>>>>> It seems that ffmpeg is trying to use altivec on PowerPC G3
> >>>>>> although it's
> >>>>>> not available. This was introduced with revision 10637. Here is a
> >>>>>> patch to
> >>>>>> fix the issue.
> >>>>>>
> >>>>>> --- libavcodec/mpegvideo.c	(revision 11880)
> >>>>>> +++ libavcodec/mpegvideo.c	(working copy)
> >>>>>> @@ -61,6 +61,10 @@
> >>>>>> extern void XVMC_decode_mb(MpegEncContext *s);
> >>>>>> #endif
> >>>>>>
> >>>>>> +#ifdef HAVE_ALTIVEC
> >>>>>> +extern int has_altivec(void);
> >>>>>> +#endif
> >>>>>
> >>>>> That #ifdef is pointless.
> >>>
> >>> seconded
> >>
> >> #ifdef HAVE_XVMC
> >> extern int  XVMC_field_start(MpegEncContext*s, AVCodecContext  
> >> *avctx);
> >> extern void XVMC_field_end(MpegEncContext *s);
> >> extern void XVMC_decode_mb(MpegEncContext *s);
> >> #endif
> >
> > I mean why do we have the above lines in the mentioned file then?
> >
> > Diego
> 
> 
> I was just about to ask the same question... We have some in a lot of  
> files.

which files?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080209/691713e9/attachment.pgp>