[FFmpeg-devel] [PATCH] remove MSVC cruft

Michael Niedermayer michaelni
Sat Feb 9 14:51:53 CET 2008


On Sat, Feb 09, 2008 at 02:09:04PM +0100, Diego Biurrun wrote:
> On Sat, Feb 09, 2008 at 02:06:01PM +0100, Diego Biurrun wrote:
> > As noted by Reimar, the following two lines in libavutil/mem.h are
> > probably MSVC cruft:
> > 
> >   #define DECLARE_ALIGNED(n,t,v)      __declspec(align(n)) t v
> >   #define DECLARE_ASM_CONST(n,t,v)    __declspec(align(n)) static const
> > 
> > I suggest the attached patch removing them.
> 
> *sigh*

I am against it.

it rather should be
#elif HAVE_DECLSPEC
#define DECLARE_ALIGNED(n,t,v)      __declspec(align(n)) t v
#define DECLARE_ASM_CONST(n,t,v)    __declspec(align(n)) static const t v
#else
#warning no align and asm directives, this might fail
#define DECLARE_ALIGNED(n,t,v)      t v
#define DECLARE_ASM_CONST(n,t,v)    static const t v
#endif

There are people who maintain a hacked up version of ffmpeg which does
compile under msvc. Theres no need to make their work harder by removing
clean and seperated code. Its only the messy parts which we should reject.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080209/2c1224b8/attachment.pgp>



More information about the ffmpeg-devel mailing list