[FFmpeg-devel] Fix headers inclusion in ffserver.c

Luca Abeni lucabe72
Fri Feb 8 19:41:06 CET 2008

Hi all,

Lucabe72 wrote:
>>> ffserver.c currently includes sys/poll.h, while poll.h seems to be the 
>>> correct header to be included... Ok to apply the attached patch?
>> if you say that the new code is better, then yes
> Well, according to all the manpages and documentation I found, poll.h is the
> right file to include for using poll().
> Rich also confirmed that poll.h is the standard header.
> I verified that including poll.h instead of sys/poll.h does not break
> compilation on linux.
> So, yes, I think that the new code is more standard. If noone complains,
> I'll commit the change this evening.
Before committing, I noticed that my patch was incomplete (the 
sys/poll.h inclusion depended on HAVE_SYS_POLL_H).

I attach the complete version (but since I'll not have a stable internet 
connection in the next days, I'll commit the patch only on Wednesday - 
unless anyone complains).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_poll_include.diff
Type: text/x-diff
Size: 2152 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080208/a42894d8/attachment.diff>

More information about the ffmpeg-devel mailing list