[FFmpeg-devel] Patch - Allow disabling of bit reservoir when encoding MP3 audio

[Paul Kelly]

On Tue, 5 Feb 2008, Michael Niedermayer wrote:

> On Tue, Feb 05, 2008 at 12:40:18AM +0000, Paul Kelly wrote:
[...]
>> Index: libavcodec/utils.c
>> ===================================================================
>> --- libavcodec/utils.c	(revision 11865)
>> +++ libavcodec/utils.c	(working copy)
>> @@ -762,6 +762,7 @@
>>  {"non_linear_q", "use non linear quantizer", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_NON_LINEAR_QUANT, INT_MIN, INT_MAX, V|E, "flags2"},
>>  {"request_channels", "set desired number of audio channels", OFFSET(request_channels), FF_OPT_TYPE_INT, DEFAULT, 0, INT_MAX, A|D},
>>  {"drc_scale", "percentage of dynamic range compression to apply", OFFSET(drc_scale), FF_OPT_TYPE_FLOAT, 1.0, 0.0, 1.0, A|D},
>> +{"disable_reservoir", "disable bit reservoir (libmp3lame)", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_DISABLE_RESERVOIR, INT_MIN, INT_MAX, A|E, "flags2"},
>
> The mentioning of libmp3lame is not appropriate. The flag is not specific to
> lame.

If the mention was removed from there and from the comment against the 
list of flags in avcodec.h, would the patch be acceptable? I take on board 
what you say about the meaning of flags being codec-independent - I've 
been looking to see if there was any other flag or option that might be 
re-used instead, e.g. something related to keyframes or inter-frame 
dependencies that could be used in a relevant way. Haven't found anything 
though but I'm not really very familiar with the code and what to be 
looking for.

Paul