[FFmpeg-devel] [PATCH] Remove illegal "inline" specifiers

Diego Biurrun diego
Sun Feb 3 18:54:33 CET 2008

On Sat, Feb 02, 2008 at 08:44:17PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 02, 2008 at 04:41:58AM +0200, Uoti Urpala wrote:
> > mpegvideo.h has two function declarations with the 'inline' specifier
> > but no definition for those functions. The C standard requires a
> > definition to appear in the same translation unit for any function
> > declared with 'inline'. Most of the files including mpegvideo.h do not
> > define those functions. The attached patch fixes this by removing the
> > 'inline' specifiers from the header.
> > 
> > Both of those functions also have the 'inline' specifier in their
> > definition. That seems stupid for at least ff_epzs_motion_search (it's
> > so big that inlining even within the translation unit where it's defined
> > is unlikely to make sense). That should probably be removed even if it's
> > not illegal. Current gcc chooses not to inline the function anyway.
> patch ok



More information about the ffmpeg-devel mailing list