[FFmpeg-devel] [PATCH]VDPAU patch for H264

[Diego Biurrun]

On Tue, Dec 30, 2008 at 02:23:07AM +0100, Carl Eugen Hoyos wrote:
> 
> Attached is a new version of the patch to implement vdpau hardware 
> decoding of H264.
> I tried to adress all issues, please be kind if I oversaw something.
> 
> Please comment, Carl Eugen
> 
> --- libavcodec/h264.c	(revision 16386)
> +++ libavcodec/h264.c	(working copy)
> @@ -72,6 +72,9 @@
>  static VLC_TYPE run7_vlc_table[96][2];
>  static const int run7_vlc_table_size = 96;
>  
> +int ff_VDPAU_h264_add_data_chunk(H264Context *h, const uint8_t *buf, int buf_size);
> +int ff_VDPAU_h264_picture_complete(H264Context *h);

Can't this be done without ugly forward declarations?

> @@ -8005,4 +8041,27 @@
>  
> +#if ENABLE_H264_VDPAU_DECODER

#ifdef CONFIG_H264_VDPAU_DECODER

> --- libavcodec/vdpauvideo.c	(revision 0)
> +++ libavcodec/vdpauvideo.c	(revision 0)
> @@ -0,0 +1,203 @@
> +
> +static void VDPAU_ensure_has_buffers(vdpau_render_state * render, int need_entries)

long line

> +{
> +    int new_alloced;

new_allocated?

> --- libavcodec/vdpau_render.h	(revision 0)
> +++ libavcodec/vdpau_render.h	(revision 0)
> @@ -0,0 +1,89 @@
> +
> +#ifndef FFMPEG_VDPAU_RENDER_H
> +#define FFMPEG_VDPAU_RENDER_H

wrong multiple inclusion guard

> +typedef struct {
> +} vdpau_render_state;

I think it would be better to do this without typedef.

Diego