[FFmpeg-devel] [PATCH] check also for $TMP in configure

Måns Rullgård mans
Mon Dec 29 13:58:29 CET 2008


Heinz Wiesinger <HMWiesinger at bnet.at> writes:

> M?ns Rullg?rd wrote:
>> Heinz Wiesinger <HMWiesinger at bnet.at> writes:
>> > Hi!
>> >
>> > Please find attached a minor patch to configure to also test for $TMP
>> > alongside $TMPDIR and $TEMPDIR.
>>
>> Is there a system where this is typically used?  Most Unix tools use
>> $TMPDIR.  I don't know the reason for the $TEMPDIR check.
>
> Slackware uses $TMP for both installing and creating
> packages. That's where I ran into an issue with ffmpeg as there's
> only a value for $TMP set and not for $TMPDIR or $TEMPDIR. (user had
> /tmp set to noexec, defined another tmp-location via $TMP, but
> ffmpeg still wanted to execute files in /tmp as $TMP was obviously
> not handled)
>
> Further research on google showed that Windows uses TMP alongside
> TEMP, and some unix software prefers $TMP over $TMPDIR, though
> wikipedia indeed said TMPDIR is the standard and others are mostly
> used on non-posix systems.
>
> I don't think this patch should cause any problems. However, if
> there are any objections on applying the patch I would also be able
> to work around it in my build script. I would prefer it being
> handled by ffmpeg though.

Checking another variable certainly won't cause any problems.  I just
don't want to add clutter without a reason.  Something using the name
is reason enough for me.

I've added it in a different way, along with some cleanup.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list