[FFmpeg-devel] [PATCH]Fix h264 decoding for icc 32 bit on sse2 cpu

Jason Garrett-Glaser darkshikari
Fri Dec 26 11:45:02 CET 2008


On Fri, Dec 26, 2008 at 5:15 AM, M?ns Rullg?rd <mans at mansr.com> wrote:
> "Jason Garrett-Glaser" <darkshikari at gmail.com> writes:
>
>> On Fri, Dec 26, 2008 at 5:07 AM, M?ns Rullg?rd <mans at mansr.com> wrote:
>>> Carl Eugen Hoyos <cehoyos at rainbow.studorg.tuwien.ac.at> writes:
>>>
>>>> Hi!
>>>>
>>>> Attached patch disables the x264 loop filter sse2 functions when
>>>> compiling with 32 bit icc. This should fix the issues with FATE.
>>>
>>> What is the underlying problem?
>>
>> The assembly functions require stack alignment which ICC apparently
>> doesn't provide.
>
> I keep hitting such problems on ARM as well, especially with armcc.
> This reliance on a nonstandard, and largely undocumented, feature of
> gcc is worrying.

According to what I remember hearing from Loren, gcc explicitly
guarantees it in the documentation, but only for x86_32.

Dark Shikari




More information about the ffmpeg-devel mailing list