[FFmpeg-devel] Patch: fix msmpeg4 dependence

[avcoder]

Dear:
VC-1 depends on msmpeg4, not msmpeg4 depends on VC-1

Please check:
vc1_decode_init(AVCodecContext *avctx) depends
on ff_h263_decode_init(AVCodecContext *avctx)

you can find the following code in the end of ff_h263_decode_init(...)

    if (ENABLE_MSMPEG4_DECODER && s->h263_msmpeg4)
        ff_msmpeg4_decode_init(s);
    else
        h263_decode_init_vlc(s);

But  vc1_decode_i_block(VC1Context *v, DCTELEM block[64], int n, int coded,
int codingset) will need :

    /* Get DC differential */
    if (n < 4) {
        dcdiff = get_vlc2(&s->gb,
ff_msmp4_dc_luma_vlc[s->dc_table_index].table, DC_VLC_BITS, 3);
    } else {
        dcdiff = get_vlc2(&s->gb,
ff_msmp4_dc_chroma_vlc[s->dc_table_index].table, DC_VLC_BITS, 3);
    }


ff_msmp4_dc_luma_vlc is only initialized in ff_msmpeg4_decode_init(...)

So the patch is needed!


On Mon, Dec 22, 2008 at 7:34 AM, John Kelley <john at kelley.ca> wrote:

> 2008/12/20 avcoder <ffmpeg at gmail.com>:
> > $as subject
> How exactly does msmpeg4 depend on VC-1?
>
>  - John
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>



-- 
--------------------------------------------
Inspired by http://ppnext.com
Your potential. Our passion.