[FFmpeg-devel] [PATCH] Port x264 SSE2 deblocking code to H.264 decoder

[Jason Garrett-Glaser]

On Fri, Dec 19, 2008 at 8:32 PM, Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> On Fri, 2008-12-19 at 19:27 -0800, Jason Garrett-Glaser wrote:
>> libavcodec requires an aligned stack on x86_32--however, as far as I
>> know, this is the first asm to be inserted into a very widely-used
>> location that explicitly requires that alignment.  If a compiler
>> cannot provide this, it cannot correctly compile libavcodec.
>
> IIRC previous libavcodec code requires that stack variables declared to
> be aligned will be aligned, and ICC _can_ provide that. If the new asm
> requires that the stack pointer itself has particular alignment, not
> just that aligned variables work, then that is a completely new
> requirement unlike anything required before.

In that case, harass Loren if you want the code modified.  Yes, the
code requires the stack pointer to be aligned.

Dark Shikari