[FFmpeg-devel] [PATCH] oops I broke rdt.c

[Ronald S. Bultje]

Hi Michael,

On Tue, Dec 16, 2008 at 10:37 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Dec 16, 2008 at 09:00:34AM -0500, Ronald S. Bultje wrote:
>> @@ -314,6 +314,7 @@
>>                                                  NULL, NULL, NULL, NULL);
>>          }
>>      } else {
>> +        rdt->audio_pkt_cnt[st->id] =
>>          ff_rm_retrieve_cache (rdt->rmctx, rdt->rmctx->pb, st, pkt);
>>          if (rdt->audio_pkt_cnt[st->id] == 0 &&
>>              st->codec->codec_id == CODEC_ID_AAC)
>
> i see code like
>  st->id = get_be16(pb);
> in rmdec.c
> thus this looks suspect, given that the array is not that large

It precedes the call to _read_mdpr(), so in rdt.c we don't use that
value (that code is never executed). Right now it's always 0. In the
future (=stream selection), it'll be set in rdt.c to a value between 0
and n_streams for that particular set of streams.

Ronald