[FFmpeg-devel] [PATCH] define _BSD_SOURCE for bktr.c

[Jacob Meuser]

On Mon, Dec 15, 2008 at 11:32:03AM -0000, M?ns Rullg?rd wrote:
> 
> Diego Biurrun wrote:
> > On Mon, Dec 15, 2008 at 02:50:48AM +0000, Jacob Meuser wrote:
> >> On Sun, Dec 14, 2008 at 02:10:03PM +0100, Diego Biurrun wrote:
> >> > On Sat, Dec 13, 2008 at 08:47:32PM +0000, Jacob Meuser wrote:
> >> > > On Sat, Dec 13, 2008 at 12:46:56PM +0100, Diego Biurrun wrote:
> >> > > > On Sat, Dec 13, 2008 at 03:01:27AM +0000, Jacob Meuser wrote:
> >> > > > > if you have specific questions, just ask.
> >> > > >
> >> > > > patch-libavcodec_ppc_check_altivec_c: could be acceptable.
> >> > > >
> >> > > > patch-configure: I merged some more parts, the rest needs an
> >> > > > explanation.
> >> > >
> >> > > haven't kept up with what is and isn't merged.  what parts still
> >> > > need to be explained?
> >> >
> >> > The patch has 17 different hunks, hunks 5-7, 13, 14 are applied, hunk
> >> > 8 has been explained, the rest is mysterious.
> >>
> >> (1) line 884 - OpenBSD has a v4l2 header as sys/videoio.h.
> >
> > This hunk is already applied.
> >
> >> (2) line 934 - use the hardware arch instead of machine arch.  this
> >> was sent to me from another developer.
> >
> > Why don't you just pass --arch=WHATEVER to configure?
> 
> If OpenBSD has a different mechanism for detecting the architecture,
> I have nothing against supporting this in a clean way.  I am, however,
> slightly confused by the hardware vs. machine distinction?  I thought
> those words were more or less synonymous.

there are, in OpenBSD, a few differences.  I don't use any of those
machines, but I believe, e.g. zaurus vs arm is an example, as
well as macppc vs powerppc.

> >> (11) line 1607 - malloc.h is deprecated, use unistd.h instead.
> >
> > You meant stdlib.h?  OpenBSD does not have malloc.h (any longer)?

oh yes, stdlib.h.

> > Anyway, malloc.h is indeed only used in a few select places:
> >
> > libavutil/mem.c:#include <malloc.h>
> > libswscale/yuv2rgb_bfin.c:#include <malloc.h>
> > libswscale/yuv2rgb_altivec.c:#include <malloc.h>
> > libswscale/swscale_bfin.c:#include <malloc.h>
> >
> > It seems safe to remove the #include in all places except mem.c, which
> 
> I see no reason for those files in libswscale to #include malloc.h.
> 
> > uses memalign().  Is there an alternative to this?
> 
> memalign() is non-standard.  The standard function is posix_memalign(),
> but I wouldn't be too surprised if OpenBSD is missing it.  It is optional
> under the standard.

yes, there is no posix_memalign in OpenBSD.

> -- 
> M?ns Rullg?rd
> mans at mansr.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
-- 
jakemsr at sdf.lonestar.org
SDF Public Access UNIX System - http://sdf.lonestar.org