[FFmpeg-devel] [PATCH] rmdec.c: implement RMVideo/AudioStream

[Michael Niedermayer]

On Sun, Dec 14, 2008 at 02:52:39PM -0500, Ronald S. Bultje wrote:
> Hi Michael,
> 
> On Sun, Dec 14, 2008 at 2:34 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> -    int curpic_num;    ///< picture number of current frame
> >> +    int curpic_num;    ///< picture number of current frame;
> >
> > ehm
> >
> >
> >>      int cur_slice, slices;
> >> -    int64_t pktpos;    ///< first slice position in file
> >> -    /// Audio descrambling matrix parameters
> >> +    int64_t pktpos;    ///< first slice position in file;
> >> +} RMVideoStream;
> >> +
> >> +typedef struct {
> >> +    ///Audio descrambling matrix parameters
> >>      uint8_t *audiobuf; ///< place to store reordered audio data
> >
> >> -    int64_t audiotimestamp; ///< Audio packet timestamp
> >> +    uint64_t audiotimestamp; ///< Audio packet timestamp
> >
> > does not belong in this patch
> 
> Sorry, typo, removed.
> 
> > i do not like this, having priv_data being 2 different structs depending on
> > codec_type needs very strong justification and a full review of the whole
> > source tree to ensure nothing can flip the type
> 
> Hm... gotcha. So I suppose a union isn't good either, right? You want
> me to just copy all values in each copy of RMStream? (I know, it's
> only a few bytes, but seems like a tiny little waste to me. :-) ). If
> so, that patch is attached. If not, I'm open for other suggestions and
> please disregard the useless attachment.

currently some variables are duplicated with lame names like
videobuf and audiobuf these obviously dont need to be duplicated
without them i think very little will be left that isnt needed by both
semantically at least, possibly rm doesnt do some thing with either type.

but thats a seperate issue so the patch is ok assuming it has been tested

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081214/3f9317ba/attachment.pgp>