[FFmpeg-devel] rtsp.c: increase SDP line buffer size

[Michael Niedermayer]

On Sun, Dec 14, 2008 at 02:09:39PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> I did this previously and need to do it again. MS-RTSP has ginormous
> headers (the whole ASF header), much bigger than RM/RDT (which is what
> the previous increase was for). Thus, the SDP line buffer size needs
> to be increased.
> 
> Ronald

> Index: ffmpeg-svn/libavformat/rtsp.c
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/rtsp.c  2008-11-30 22:20:17.000000000 -0500
> +++ ffmpeg-svn/libavformat/rtsp.c       2008-12-04 09:05:12.000000000 -0500
> @@ -567,7 +569,7 @@
>  {
>      const char *p;
>      int letter;
> -    char buf[2048], *q;
> +    char buf[8192], *q;
>      SDPParseState sdp_parse_state, *s1 = &sdp_parse_state;
> 
>      memset(s1, 0, sizeof(SDPParseState));

a comment that explains why it has the size it has would be nice
beside this, i think its ok (if our rtsp maintainer doesnt review it)


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081214/3f5f6dd3/attachment.pgp>