[FFmpeg-devel] [PATCH] Make register_codec() call avcodec_init()

Michael Niedermayer michaelni
Sun Dec 14 16:49:08 CET 2008


On Sun, Dec 14, 2008 at 04:08:45PM +0100, Stefano Sabatini wrote:
> On date Sunday 2008-12-14 02:19:02 +0100, Michael Niedermayer encoded:
> > On Sun, Dec 07, 2008 at 08:02:22PM +0100, Stefano Sabatini wrote:
> > > Hi all,
> > > 
> > > I've not a very strong opinion on this, but this way is safer,
> > > otherwise we can have an user register and use a codec which won't
> > > work. This is also more consistent with the use of av_register_all().
> > > 
> > > Regards.
> > > -- 
> > > FFmpeg = Frenzy and Fundamental Minimalistic Puritan Enhancing Gorilla
> > 
> > > Index: libavcodec/avcodec.h
> > > ===================================================================
> > > --- libavcodec/avcodec.h	(revision 16030)
> > > +++ libavcodec/avcodec.h	(working copy)
> > > @@ -31,7 +31,7 @@
> > >  
> > >  #define LIBAVCODEC_VERSION_MAJOR 52
> > >  #define LIBAVCODEC_VERSION_MINOR  6
> > > -#define LIBAVCODEC_VERSION_MICRO  0
> > > +#define LIBAVCODEC_VERSION_MICRO  1
> > >  
> > >  #define LIBAVCODEC_VERSION_INT  AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \
> > >                                                 LIBAVCODEC_VERSION_MINOR, \
> > > @@ -2563,6 +2563,11 @@
> > >   */
> > >  void avcodec_init(void);
> > >  
> > > +/**
> > > + * Register the codec \p format. Also initialize libavcodec.
> > 
> > codec format?
> 
> I'm attaching a patch which changes "format" to a more explicit "codec".

patches look good

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081214/880d910b/attachment.pgp>



More information about the ffmpeg-devel mailing list