[FFmpeg-devel] [PATCH] Make register_codec() call avcodec_init()

[Michael Niedermayer]

On Sun, Dec 07, 2008 at 08:02:22PM +0100, Stefano Sabatini wrote:
> Hi all,
> 
> I've not a very strong opinion on this, but this way is safer,
> otherwise we can have an user register and use a codec which won't
> work. This is also more consistent with the use of av_register_all().
> 
> Regards.
> -- 
> FFmpeg = Frenzy and Fundamental Minimalistic Puritan Enhancing Gorilla

> Index: libavcodec/avcodec.h
> ===================================================================
> --- libavcodec/avcodec.h	(revision 16030)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -31,7 +31,7 @@
>  
>  #define LIBAVCODEC_VERSION_MAJOR 52
>  #define LIBAVCODEC_VERSION_MINOR  6
> -#define LIBAVCODEC_VERSION_MICRO  0
> +#define LIBAVCODEC_VERSION_MICRO  1
>  
>  #define LIBAVCODEC_VERSION_INT  AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \
>                                                 LIBAVCODEC_VERSION_MINOR, \
> @@ -2563,6 +2563,11 @@
>   */
>  void avcodec_init(void);
>  
> +/**
> + * Register the codec \p format. Also initialize libavcodec.

codec format?

and iam mostly ok with the patch in principle

[...]
> Index: libavformat/allformats.c
> ===================================================================
> --- libavformat/allformats.c	(revision 16030)
> +++ libavformat/allformats.c	(working copy)
> @@ -47,7 +47,6 @@
>          return;
>      initialized = 1;
>  
> -    avcodec_init();
>      avcodec_register_all();
>  

please generate patches with svn di -x -p, also dont hesitate to tell
others who dont, it is occasionally quite usefull

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081214/d98b47f3/attachment.pgp>