[FFmpeg-devel] Various small fixes

[Diego Biurrun]

On Sat, Dec 13, 2008 at 05:20:21PM +0100, Anders Gr?nberg wrote:
> On Sat, Dec 13, 2008 at 3:52 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
> > "Anders Gr?nberg" <galileo.m2 at gmail.com> writes:
> >
> >> I have been experimenting with FFmpeg and this patch fixes some small
> >> issues I found in the code base that should be beneficial to other
> >> FFmpeg developers.
> >>
> >> --- libavformat/mov.c (revision 16089)
> >> +++ libavformat/mov.c (working copy)
> >> @@ -166,7 +166,7 @@
> >>
> >> -static const MOVParseTableEntry mov_default_parse_table[];
> >> +const MOVParseTableEntry mov_default_parse_table[];
> >
> > Why?
> The c99 standard says that a forward declaration of an array of
> unknown size should not contain the static keyword, it should only be
> present when the finale size is known. A static forward declaration of
> an array of unknown size is undefined behavior.
> Although if it doesn't compile on gcc it should be left as it is.

The best solution would appear to move the table to get rid of the
forward declaration...

Diego