[FFmpeg-devel] NC4600 camera code

[Diego Biurrun]

On Sat, Dec 13, 2008 at 08:52:38AM -0500, nicolas martin wrote:
> > On Sat, Dec 13, 2008 at 08:10:28AM -0500, nicolas martin wrote:
> >>> On date Friday 2008-12-12 22:01:34 -0500, nicolas martin encoded:
> >>>> Humm ...
> >>>> I would really like to but should i send a patch for every file I
> >>>> modified ?
> >>>
> >>> svn is your friend (hint, a patch may contain more than one file
> >>> diff). Also read *carefully* the patch submission guidelines which  
> >>> you
> >>> can find here:
> >>> http://ffmpeg.mplayerhq.hu/general.html#SEC26
> >>
> >> Regarding those rules, I made a patch, but a lot of the changes are
> >> wrong space indents ...
> >> In the rules it is said to have 4 space indentation, in the svn code,
> >> sometimes there are 5 ...
> >
> > No, you are mistaken.  Stop using tabs and do not add trailing
> > whitespace.
> Well if i could find a way how to ...
> I thought I configured my emacs to do so ...
> I would like to find *working* information on this ...

Here's what I use:

(setq-default indent-tabs-mode nil)
(setq-default show-trailing-whitespace t)

> > Your patch pointed out a few places in FFmpeg with less than optimal
> > indentation.  This is now fixed.
> 
> Well that's cool.
> Should i resubmit a patch with those tabs and bad indents removed ?

If you want to see the patch reviewed and possibly included...

Diego