[FFmpeg-devel] how do you like your patches...?

[David Conrad]

On Dec 10, 2008, at 5:26 PM, Chris Stones wrote:

> I have found a few minor bugs while trying to compile minimal  
> versions of
> ffmpeg.
> For example..
>
> building a library that will only decode theora...
> ./configure --disable-decoders --enable-decoder=theora { etc etc etc}
>
> will eventually crap out during compile with a linker error because  
> the
> theora decoder uses dome of the vp3 decoder functions.
>
> from memory, its somthing like..
>
> #if defined(THEORA_ENABLED || VP3_ENABLED)
>     vp3_do_stuff();
>     etc etc etc
>
>
> What would be the correct fix...
>
> 1) crap out during the configure script, asking the user to re- 
> configure
> with vp3 support ?
> 2) compile only the vp3 code that theora decoder requires, but not  
> the full
> decoder ?

This, although I think the only thing that Theora doesn't use is VP3's  
AVCodec struct.

Also, attached patch should fix it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: theora-mmx.diff
Type: application/octet-stream
Size: 679 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081210/ac3d42c2/attachment.obj>
-------------- next part --------------