[FFmpeg-devel] [PATCH] add tag/comment support to the raw flac demuxer

[Jethro Walters]

--- On Thu, 4/12/08, Michael Niedermayer <michaelni at gmx.at> wrote:

> From: Michael Niedermayer <michaelni at gmx.at>
> Subject: Re: [FFmpeg-devel] [PATCH] add tag/comment support to the raw flac demuxer
> To: "FFmpeg development discussions and patches" <ffmpeg-devel at mplayerhq.hu>
> Date: Thursday, 4 December, 2008, 7:30 PM
> On Thu, Dec 04, 2008 at 11:06:34AM -0800, Baptiste Coudurier
> wrote:
> > Hi,
> > 
> > Michael Niedermayer wrote:
> > > On Mon, Dec 01, 2008 at 02:18:02PM -0800, Jim Radford wrote:
> > >> This patch adds support for parsing vorbis comments in plain flac
> > >> streams.  Only metadata packets are parsed leaving the frame data to
> > >> be parsed in raw 1024 byte chunks like before.
> > > 
> > > this wont work with flac in any container short of raw flac.
> > > Thus IMO this is unacceptable
> > > 
> > 
> > It's not like flac would be put in another
> container, except ogg and 
> > this would be a lot worse, and I personnally don't
> care about flac in ogg.
> 
> flac in ogg is idiotic but isnt anyone recording music
> videos ... with lossless audio from a cd?
> For that use case (and i do not know if anyone is actually using that use
> case) flac in some non ogg container would be a possible option

FLAC in OGG may be idiotic from a software engineer's perspective (especially after reading some of the stuff on this mailing list), but from what I read it's reliable for streaming, if a bit far out.

> > I guess 90% of flac files are lossless cd audio ripping scene, and in 
> > this case this patch really adds a feature which can be removed later if 
> > someone volonteer to do something at codec level.
> > 
> > This is IMHO acceptable, and I'd like it in svn.
> 
> ill review it then
> 
[...]