[FFmpeg-devel] Realmedia patch

Luca Abeni lucabe72
Sun Aug 31 23:11:43 CEST 2008

Hi Ronald,

Ronald S. Bultje wrote:
>>> And here's #2. With the previous patches applied, I can play RTSP streams.
>> Ok, good. Can you check if there are previous patches which still need
>> feedback?
> In my tree, I have (right now):
Ok, thanks for the update; it looks like we are converging ;-)

>>> +finalize_packet(RTPDemuxContext *s, AVPacket *pkt, uint32_t ts)
>> Why this separate function? It looks useless.
> I'll remove it, it's a leftover from trying to quickly rip out the
> relevant code from rtp.c. I moved it to rdt_parse_packet(), all the
> way at the bottom (the stream_index was already set there, I added a
> line for the pts).

I think you can just do
	rv= rdt_parse_packet(s, pkt, &pkt->timestamp, ...);
saving a variable and two lines of code ;-)


More information about the ffmpeg-devel mailing list