[FFmpeg-devel] [PATCH] increase SDP buffer size

Michael Niedermayer michaelni
Sun Aug 31 17:14:23 CEST 2008

On Sun, Aug 31, 2008 at 10:11:53AM -0400, Ronald S. Bultje wrote:
> Hi,
> I've found some streams with SDP lines longer than 1024 bytes.
> Currently, rtsp.c discards those extra bytes, leading to incomplete
> SDP parsing and failure to play/offer some streams (or offer them
> incorrectly) in the RTSP client.
> Attached patch detects those, adds an av_log(ERROR) so we can detect
> when it happens (instead of silently losing data) and increases the
> buffersize to handle the stream that failed for me like this:

i think the 1024->2048 is ok even though iam not maintainer

the rest does not like it is the minimal way to print an error message
nor that it is correct, i mean the thing should return -1 or something
like that in case of an error not print a warning and continue with a
randomly truncated line.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080831/3411ed8b/attachment.pgp>

More information about the ffmpeg-devel mailing list