[FFmpeg-devel] DVCPRO HD: request for review

Roman V. Shaposhnik rvs
Sat Aug 30 22:39:58 CEST 2008

On Sat, 2008-08-30 at 00:44 +0200, Michael Niedermayer wrote:
> > My only comment then would be -- we have to have timeouts. As reasonable
> > developers we all know truly ugly code when we see it. It doesn't
> > take time to respond with: "its ugly, it needs to be speeded up, and
> > no I don't want to think about how exactly". I submitted my original
> > patch on Aug 17. Since then I gave you at least 3 extra chances to
> > comment on *everything* in the patch. And after 2 weeks it is only
> > now that you've found it possible to comment on the issues like 
> > the for loop in the previous email (which I assumed to be implicitly
> > ok'ed).
> You are not the only one that submitts patches, besides others there are
> also 8 students working for ffmpeg who send patches and have questions
> currently.
> I did never try to completely review your patch, i tried to give you
> a few points you can work on, and planned to continue the review
> when you did finish them.

Well, since in your last review you didn't identify any new issues in
a *complete* patch that I've submitted I assumed that you were ok
with everything in there. But I told you so already.

If I go over the *complete* patch and cross out all of the hunks 
you've already OKed that leaves us with the patch in the attachment.
Lets work from there. It has a grand total of 10 unOKed hunks.
Can you, please, let me know the rough estimate of when do 
you think you can review them?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: unoked.patch
Type: text/x-patch
Size: 11891 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080830/5437cbec/attachment.bin>

More information about the ffmpeg-devel mailing list