[FFmpeg-devel] [PATCH] codec_has_pameters and sample_fmt

[Peter Ross]

On Fri, Aug 29, 2008 at 11:04:43PM +0200, Michael Niedermayer wrote:
> On Fri, Aug 29, 2008 at 01:08:50PM -0700, Baptiste Coudurier wrote:
> > Hi
> > 
> > I think codec_has_parameters should return true only if sample_fmt has
> > been determined for audio codecs.
> > 
> > It seems libavcodec still sets it to S16 atm, so it does no harm,
> > however this will be needed.
> 
> patch ok
> 
> 
> > 
> > I missed a bit this thread, but when will avcodec set sample_fmt to NONE
> > by default ?
> 
> when peter changes it, IIRC ive approved it being changed as soon as
> it does work ...

The seemingly innocent S16->NONE change breaks the seek regression test
for AC3 (within RM container). I have enclosed fix this *but* i am not
really sure "why" this fixes it. Ideas, anyone?

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sample_fmt_none_aac_ac3_parser.diff
Type: text/x-diff
Size: 481 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080830/96d08f29/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080830/96d08f29/attachment.pgp>