[FFmpeg-devel] [PATCH] flv demux cleanup

Michael Niedermayer michaelni
Fri Aug 29 23:00:11 CEST 2008


On Fri, Aug 29, 2008 at 11:14:21AM -0700, Baptiste Coudurier wrote:
> Hi
> 
> flv_simplify_size_code.patch:
> 
> This 'size - 1' all around is kinda confusing.

ok


> 
> flv_factorize_skip.patch

ok


> 
> flv_factorize_flags.patch

IMHO this is making the code uglier


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080829/1ac97eba/attachment.pgp>



More information about the ffmpeg-devel mailing list