[FFmpeg-devel] [PATCH] Fix crash in libx264 when rc_eq is not set

Stefano Sabatini stefano.sabatini-lala
Fri Aug 29 19:39:18 CEST 2008


On date Thursday 2008-08-28 16:22:35 -0700, Baptiste Coudurier encoded:
> Stefano Sabatini wrote:
> > On date Thursday 2008-08-28 23:56:21 +0100, M?ns Rullg?rd encoded:
> >> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
> >>
> >>> Hi,
> >>>
> >>> Loren Merritt wrote:
> >>>> On Fri, 29 Aug 2008, Stefano Sabatini wrote:
> >>>>
> >>>>> -    x4->params.rc.psz_rc_eq = avctx->rc_eq;
> >>>>> +#if X264_BUILD < 61
> >>>>> +    if (avctx->rc_eq)
> >>>>> +        x4->params.rc.psz_rc_eq = avctx->rc_eq;
> >>>>> +#else
> >>>>> +        av_log(avctx, AV_LOG_WARNING, "Ignoring the rc_eq set, using the libx264 default one\n");
> >>>>> +#endif
> >>>> Unconditionally print a warning if it's compiled with new libx264?
> >>>>
> >>> I'd say no ifdefery, remove the line.
> >> Agree.
> > 
> > Ok for the warning?
> 
> IMHO the warning is useless, and atm we don't warn user for options
> which has no effects on codec actually used... this requires much code
> but might be welcome.

Fine, applied the version which simply removes the line which seems
the version on which most (Mans between them) agree.

Regards.
-- 
FFmpeg = Fantastic Frightening Martial Prodigious Elegant Gadget




More information about the ffmpeg-devel mailing list