[FFmpeg-devel] [PATCH] specify a name/description per stream

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Wed, Aug 27, 2008 at 08:04:13PM +0200, Aurelien Jacobs wrote:
> [...]
> > > > [...]
> > > >  
> > > > Index: libavformat/avformat.h
> > > > ===================================================================
> > > > --- libavformat/avformat.h	(revision 14980)
> > > > +++ libavformat/avformat.h	(working copy)
> > > > @@ -409,6 +409,8 @@
> > > >       * - decoding: Set by libavformat.
> > > >       */
> > > >      AVRational sample_aspect_ratio;
> > > > +
> > > > +    char *name;  /**< name/description of the track */
> > > >  } AVStream;
> > > 
> > > Maybe char name[1024] is preferrable, like all other metadata in
> > > AVFormatContext ?
> > 
> > I tried to be consistent with other fields in AVStream, such as
> > filename. If an array is really preferred I can change it.
> > Any other opinion about this.
> 
> a more generic metadata API may be interresting
> Especially with user specified keys instead of "name" "author", ...
> the current system would break down.

I agree that a more generic metadata API would be useful.
But you should note that my current patch is not about adding
a new metadata field in AVFormatContext. It's about adding a
specific field in AVStream.
Well, I guess that a generic metadata API could also be used
per stream, but I wonder if this wouldn't be overkill. I doubt
that any muxer could really fully benefit from it.
So do you place the generic metadata API as a strong requirement
to export the stream name, or would my patch be an acceptable way
to do it, at least in the mean time ?

Aurel