[FFmpeg-devel] Realmedia patch

Ronald S. Bultje rsbultje
Wed Aug 27 15:06:44 CEST 2008


Hi,

On Wed, Aug 27, 2008 at 8:43 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> inOn Wed, Aug 27, 2008 at 08:39:11AM -0400, Ronald S. Bultje wrote:
>> Hi Michael,
>>
>> On Wed, Aug 27, 2008 at 8:27 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > Let me try again :(
>> >
>> > ff_data_to_hex must not be in a public header not directly or indirectly.
>> > NO public header must EVER include a non public header.
>> > avformat.h is a public header
>>
>> Sorry, the same scheme is used in lavu/common.h, I just moved on from there...
>
> no
>
> lavu/common.h
> uses:
> #ifdef HAVE_AV_CONFIG_H
> #    include "internal.h"
> #endif /* HAVE_AV_CONFIG_H */
>
> So it only includes the internal header when common.h is used internally

Same here, see grep HAVE_AV_CONFIG_H libavformat/avformat.h.

Ronald




More information about the ffmpeg-devel mailing list