[FFmpeg-devel] Realmedia patch
Wed Aug 27 14:27:52 CEST 2008
On Wed, Aug 27, 2008 at 08:00:44AM -0400, Ronald S. Bultje wrote:
> Hi Aurel,
> On Wed, Aug 27, 2008 at 7:53 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > Ronald S. Bultje wrote:
> >> On Wed, Aug 27, 2008 at 2:34 AM, Diego Biurrun <diego at biurrun.de> wrote:
> >> > On Tue, Aug 26, 2008 at 09:38:03PM -0400, Ronald S. Bultje wrote:
> >> >>
> >> >> On Tue, Aug 26, 2008 at 9:34 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> >> >> > avformat_internal.h ? The "avformat_" here is redundant. Just call
> >> >> > it internal.h.
> >> >>
> >> >> Won't that clash with lavutil/internal.h?
> >> >
> >> > Since we require full #include paths for files from other directories,
> >> > i.e. '#include "libavutil/internal.h"', it really should not, unless
> >> > somebody has set -I flags. But people really should not...
> > We already have libavcodec/raw.h and libavformat/raw.h.
> > So people compiling FFmpeg with some stupid -I flags should be
> > prepared to surprises.
> >> lavu/common.h includes internal.h, not lavu/internal.h
> > So what ? internal.h will be searched in the same directory than the
> > file which included it, ie. lavu.
> OK, I didn't know that. Patch attached with your suggested modification then.
Let me try again :(
ff_data_to_hex must not be in a public header not directly or indirectly.
NO public header must EVER include a non public header.
avformat.h is a public header
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel