[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi Michael,

On Sun, Aug 24, 2008 at 10:33 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Aug 24, 2008 at 09:55:53PM -0400, Ronald S. Bultje wrote:
>> Hi Michael,
>>
>> On Thu, Aug 21, 2008 at 12:05 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Mon, Aug 18, 2008 at 10:21:35AM -0400, Ronald S. Bultje wrote:
>> [..]
>> >> +    hex_table[16] = { '0', '1', '2', '3', '4', '5', '6', '7',
>> >> +        '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };
>> [..]
>> >> +    /* convert zres to ascii string */
>> >> +    for (i = 0; i < 16; i++) {
>> >> +        response[i * 2]     = hex_table[zres[i] >> 4];
>> >> +        response[i * 2 + 1] = hex_table[zres[i] & 0xf];
>> >> +    }
>> >
>> > grep hex */*.c shows that there are several existing data->hex converters
>> > thus this is duplicate
>>
>> Attached patch exports the existing one in sdp.c into utils.c with
>> declaration in avformat.h.
>
> avformat.h is a public header the function is not supposed to be public.
>
> besides this is not exporting it is removing and adding a different one.
> That should be 2 patches
> * move
> * change implementation

How about this for a move?

- avformat.h includes avformat_internal.h, similar to lavu/internal.h
being included (conditionally, depending on HAVE_AV_CONFIG_H) in
lavu/common.h
- implementation moved
- decl in lavf/avformat_internal.h

In later patches, I could move other conditional stuff from avformat.h
(see bottom) to avformat_internal.h also.

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sdp-export-data_to_hex.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080826/e89a0296/attachment.asc>