[FFmpeg-devel] [PATCH] Remove MULL macro from lsp.c

Michael Niedermayer michaelni
Tue Aug 26 17:34:56 CEST 2008

On Tue, Aug 26, 2008 at 09:35:04PM +0700, Vladimir Voroshilov wrote:
> 2008/8/26 Michael Niedermayer <michaelni at gmx.at>:
> [...]
> > But at this point we do not know at all if such signals really are possible
> > as input to the filter.
> >
> > If they are then the comments about the bits in the variables are wrong if
> > not then the claim of the clip() being required is wrong. As is the comments
> > are plain contradictionary. And i would like to see them fixed or removed.

> With "+0x800" rounding, overflow occurs also in ALGTHM and SPEECH tests.
> The latter is regular (at least it looks like) speech recording.

So please add a comment like:
"With "+0x800" rounding, cliping is needed for ALGTHM and SPEECH"

> And i agree that comments are not clear.
> Thus i prefer removing comments but keep clipping. Patch is attached.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080826/59058191/attachment.pgp>

More information about the ffmpeg-devel mailing list