[FFmpeg-devel] [PATCH] Remove MULL macro from lsp.c

Vladimir Voroshilov voroshil
Tue Aug 26 16:35:04 CEST 2008

2008/8/26 Michael Niedermayer <michaelni at gmx.at>:


> But at this point we do not know at all if such signals really are possible
> as input to the filter.
> If they are then the comments about the bits in the variables are wrong if
> not then the claim of the clip() being required is wrong. As is the comments
> are plain contradictionary. And i would like to see them fixed or removed.

With "+0x800" rounding, overflow occurs also in ALGTHM and SPEECH tests.
The latter is regular (at least it looks like) speech recording.
And i agree that comments are not clear.
Thus i prefer removing comments but keep clipping. Patch is attached.

Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: high_pass_filter_fix.diff
Type: text/x-diff
Size: 872 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080826/cb58e71a/attachment.diff>

More information about the ffmpeg-devel mailing list